Avoid rebuilding buffered queries - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the query execution logic in
QueryResultto improve efficiency when dealing with buffered results, especially for nested collections. The main enhancement ensures that if a batch result is already available in the buffer, the query builder is not unnecessarily reconstructed. Additionally, a new test is added to verify this behavior.Query execution optimization
QueryResult::__constructto check for an existing batch result in the buffer before rebuilding the query builder, preventing redundant query construction and improving performance for nested collection queries. [1] [2]queryBuilderif available, or create a new one only when necessary.Testing
tests/QueryResultTest.phpwith a test case to confirm that when a buffered nested result exists, the query builder is not rebuilt, ensuring the optimization works as intended.